n5ro / aframe-physics-system

Physics system for A-Frame VR, built on CANNON.js.
https://n5ro.github.io/aframe-physics-system/
MIT License
507 stars 137 forks source link

Don't take browserify and budo as first-class deps #107

Closed mqp closed 6 years ago

mqp commented 6 years ago

Perhaps I'm misunderstanding something, but it seems to me that these are already in the devDependencies, and it doesn't seem to me like they ought to be in the ordinary dependencies.

(This can matter to upstream packages, since it means that upstream packages will have to take the time to install these dependencies even if they use a different build toolchain that doesn't need them.)

donmccurdy commented 6 years ago

Thanks! Could you omit the package-lock.json commit? I'll just rebuild it before the next release.

mqp commented 6 years ago

OK, rewrote to just leave package-lock.json alone.

donmccurdy commented 6 years ago

Thanks! :)