n64blog / n64blog.github.io

Blog dedicated to everything N64
http://www.n64blog.com
0 stars 1 forks source link

Redundant labelling on gamepages #35

Closed guypursey closed 7 years ago

guypursey commented 7 years ago

Some labels, like "Related posts" and Japanese release date labels, need hiding where there is no content to be found. Suggest some conditionals in the template files which would wrap these labels and any associated tags and only show them where there's a relevant value.

Here's an image of what I mean:

n64-blog-gamepages-redundant-labelling

ash-lift commented 7 years ago

@guypursey I've taken a look and can't figure out a conditional that will fix this without breaking something else. Any ideas?

guypursey commented 7 years ago

@ash-lift: I wasn't sure what you meant but guessed that it might be the "Related posts" label as the release date labels all seemed to be set up with conditionals correctly. Don't know what you tried but I ended up having to rewrite the way the tags and posts arrays were handled slightly. Happy to provide more detail if you want it!

ash-lift commented 7 years ago

Thanks for looking at this, yes I already sorted the release date labels, it was the related posts that were causing issues as the loop never returned empty but you've sorted that out :)

ash-lift commented 7 years ago

Fixed in #44