search

n64decomp / mk64

A speedy Mario Kart 64 decompilation, brought to you by the cousin of a tame racing driver.
588 stars 67 forks source link

Match func_8009A374 #592

Closed spazzylemons closed 5 months ago

spazzylemons commented 5 months ago

Overwriting the parameter variable was all that was needed to match this one

Tmcg2 commented 5 months ago

Nice, this one has eluded me for a long time. Makes me wonder if func_8009A478 can get rid of the fakematch with similar changes

spazzylemons commented 5 months ago

Nice, this one has eluded me for a long time. Makes me wonder if func_8009A478 can get rid of the fakematch with similar changes

@Tmcg2 turns out, yes! https://decomp.me/scratch/XAtLq I can add this to this PR if you'd like

Tmcg2 commented 5 months ago

Sure, that would be great!

spazzylemons commented 5 months ago

Just pushed the func_8009A478 changes

MegaMech commented 5 months ago

Could you please delete the 2nd function.s file since you matched 2 functions?

Tmcg2 commented 5 months ago

func_8009A374 is near identical to func_8009A478, and spazzylemon's way of matching func_8009A374 turned out to fix the fakematch in func_8009A478. The .s file for func_8009A478 ought to have been deleted months ago.

MegaMech commented 5 months ago

Just to clarify,

you're suggesting that there's 2 more .s function files that should be deleted in this PR?

Tmcg2 commented 5 months ago

No, I'm saying the one file he did delete is the only file that needs deleting. The .s file for the other function was deleted months ago

MegaMech commented 5 months ago

OOoooh I get it now. Thanks!