search

n6g7 / redux-saga-firebase

A redux saga integration for firebase.
https://redux-saga-firebase.js.org/
MIT License
284 stars 57 forks source link

Can options be passed to Firestore syncCollection/SyncDocument? #134

Open ted-nz opened 6 years ago

ted-nz commented 6 years ago

Specifically, wish to be able to listen to meta-data changes, i.e. includeMetadataChanges = true. Looking at the channel implementation, doesn't look like this is currently supported?

n6g7 commented 6 years ago

Hey, you're right this is not supported at the moment but a PR would be welcome. :)

ted-nz commented 6 years ago

Thanks for the confirmation @n6g7 , I have a use case where I want some UI indication that goes something like "hey, the information you saved is not visible to the world yet", and ideally need a relatively quick and snappy means of detecting when this has happened.

I'll have a go at it over the next little while and see what comes of it.

n6g7 commented 6 years ago

Cool! I think it should be a relatively simple feature to add, let me know if you need any help. :)

ted-nz commented 6 years ago

Hi @n6g7 I took a stab at it and opened a PR (https://github.com/n6g7/redux-saga-firebase/pull/135). Appreciate it if you can take a quick look, cheers.

n6g7 commented 6 years ago

Thanks for sending a PRn @ted-aux, I just merged and I'll make a release soon. Keeping this issue open until then. :)

ted-nz commented 6 years ago

:+1: Cheers

yash2code commented 5 years ago

is it working ?