This makes sense, but is rather slow and not strictly necessary (mostly to clean old data from DB).
Performance of this check with a large database is actually so bad that DejaVu may end up as most battery consuming app (according to battery usage in Android settings).
Proposed improvements:
getExpected() queries emitters from DB by latitude, longitude and type, so we should add an index on latitude, longitude and type to the database.
we get all types of emitters from DB, with the purpose of decreasing trust of the ones we expect, but could not find. But EmitterType.MOBILE has decrTrust 0, so trust cannot be decreased. There is no point in fetching MOBILE emitters from DB.
emitterCache.sync(); is not necessary: the only emitters that are not in DB (or are not updated) are emitters we have in seenSet, and the only purpose of the expected check is decreasing trust of expected emitters that are not in the seenSet.
(+some more potential improvements that require more changes)
At the end of each reporting period, a check for missing emitters is done: https://github.com/n76/DejaVu/blob/e54aae2d9f3d4619065a258b431ace1911d1e931/app/src/main/java/org/fitchfamily/android/dejavu/BackendService.java#L976-L993
This makes sense, but is rather slow and not strictly necessary (mostly to clean old data from DB). Performance of this check with a large database is actually so bad that DejaVu may end up as most battery consuming app (according to battery usage in Android settings).
Proposed improvements:
getExpected()queries emitters from DB by latitude, longitude and type, so we should add an index on latitude, longitude and type to the database.EmitterType.MOBILEhasdecrTrust0, so trust cannot be decreased. There is no point in fetchingMOBILEemitters from DB.emitterCache.sync();is not necessary: the only emitters that are not in DB (or are not updated) are emitters we have inseenSet, and the only purpose of the expected check is decreasing trust of expected emitters that are not in theseenSet.