n76 / DejaVu

Yet another network location backend for the UnifiedNLP/microG project
GNU General Public License v3.0
100 stars 18 forks source link

Ignore invalid LAC #48

Open Helium314 opened 2 years ago

Helium314 commented 2 years ago

I noticed some bad GSM-based location reports with LAC (location area code) 0. However, at least for GSM cells (maybe others as well), a valid LAC can't be 0, see

Location Area Code (LAC) which is a fixed length code (of 2 octets) identifying a location area within a GSM PLMN. This part of the location area identification can be coded using a full hexadecimal representation except for the following reserved hexadecimal values: 0000, and FFFE.

from https://www.etsi.org/deliver/etsi_ts/123000_123099/123003/03.07.00_60/ts_123003v030700p.pdf

Proposed solution: Treat LAC 0 as invalid.

(related to #33)