search

n8chz / prostetnic

The prostetnic highlighter, a Firefox add-on for highlighting text in web pages.
8 stars 3 forks source link

Does not work on Firefox 46 #11

Open marcbelmont opened 8 years ago

marcbelmont commented 8 years ago
GitHubAndProstetnic commented 8 years ago

Dear Marc,

Please note that I have gravitated to Wired-Marker, after first having tried your highlighter. I could never get your app to work for me. Wired-Marker is relatively problem free and has additional properties that make it a more comprehensive application for research. If you haven't looked at it I suggest that you do in order to get some idea what another group has done quite successfully. It may give you some good ideas on how to improve your highlighter. After about 2 years of use I have no worries that things I've highlighted might disappear after all the work put into the task of highlighting, which appears to be an issue of most other highlighters.

Best regards,

Wallace G. Diehl

DIEHL ENGINEERING COMPANY

From: Marc Belmont [mailto:notifications@github.com] Sent: Tuesday, May 3, 2016 1:36 AM To: n8chz/prostetnic Subject: [n8chz/prostetnic] Does not work on Firefox 46 (#11)

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/n8chz/prostetnic/issues/11 https://github.com/notifications/beacon/AHgCA7MEL4GO552UBwNysyXxG4pWqRygks5 p9wjigaJpZM4IWBgq.gif

marcbelmont commented 8 years ago

Thanks for the tip.

n8chz commented 8 years ago

Use of simple-storage for storing color presets, it turns out, was a mistake, as simple-storage isn't really non-volatile. For one thing, it tends to evaporate during Firefox version upgrades. Combine this with a bug in my own code that requires the first color selection before the first highlight and it appears not to work following an upgrade. If you do a color selection before doing a highlight, it will probably work. I was going to switch color presets from simple-storage to storage API (which I use for the highlights themselves) but now Mozilla is phasing out XPCOM (which storage API is part of) in favor of "WebExtensions" (part of their ongoing project of morphing Firefox into a largely uninspired Chrome clone). This means I will probably have to re-write the whole thing from scratch, which could be a good thing. I've already written a Chrome version, which is more reliable (but includes a rather small subset of the features). I have not succeeded at porting it back to Firefox, as the "storage" API of WebExtensions has not (yet?) been fully implemented in Firefox.

marcbelmont commented 8 years ago

Thanks for the update and good luck on the re-write.

GitHubAndProstetnic commented 8 years ago

Hi Marc,

"Re-write"? Ouch! I'm still recovering from Windows 10. Anyway the thing for me, that gives me confidence in Wired-Marker, is the easy access to where the highlights are stored.

In my line of work the K-I-S-S (Keep-It-Simple-Stupid) principle seems to be somewhat fool proof, until it isn't.

I hope that helps.

Regards,

Wally Diehl

DIEHL ENGINEERING COMPANY

From: Marc Belmont [mailto:notifications@github.com] Sent: Sunday, May 8, 2016 1:54 PM To: n8chz/prostetnic Cc: GitHubAndProstetnic; Comment Subject: Re: [n8chz/prostetnic] Does not work on Firefox 46 (#11)

Thanks for the update and good luck on the re-write.

You are receiving this because you commented. Reply to this email directly or view https://github.com/n8chz/prostetnic/issues/11#issuecomment-217745489 it on GitHub https://github.com/notifications/beacon/AHgCA6pszGSexARRCYtRznHcDutwRHSRks5 p_k11gaJpZM4IWBgq.gif