n8chz
commented
9 years ago That was something of a design dilemma. I could record (say) the string position within the page's textContent of the beginning of the selection, and then the question of which of several passages were highlighted would be unambiguous, IF the page content hasn't changed between sessions. That would necessitate changing the data schema, coming up with a policy for highlights logged with prior versions (even if it's the same policy, making it an exception to the position-aware scheme would be some amount of new code). Bottom line: matching text passages within a URL that is subject to editing and other revisions is a non-trivial problem with no non-ambiguous solution. I don't know whether I'll be addressing your specific concern at some point. If so, it will probably be in the context of a major rewrite.
On re-visit, the highlight is applied to the last matching passage. That was of course an arbitrary decision. The relevant code is in data/hilite.js, at like 53 I suppose highlighting all instances would involve replacing the rightmostMatch method with one that returns an array of all matches, and replacing the if structure that starts at line 59 with a .forEach call over the elements in the resulting array.
GitHubAndProstetnic
I noticed that if there are duplicate instances of a saved highlight on a page prostetnic only highlights one of them randomly. Would it be possible to have it highlight all instances?