search

n8chz / prostetnic

The prostetnic highlighter, a Firefox add-on for highlighting text in web pages.
8 stars 3 forks source link

Consider removing color/style from text/links #7

Open davidhedlund opened 9 years ago

davidhedlund commented 9 years ago

There's no reason to add under line nor make all text black. Links have their own color so under line is not needed at all. This just make things more complicated. Keep it to background color only because that is what this add-on should do, not more or less.

n8chz commented 9 years ago

Whether links are underlined at all is determined by the page's CSS. Many sites, such as Wikipedia, mark links by color difference rather than underlining. If foreground and background colors are uniform throughout a text range that will effectively obliterate any link markings within that range, unless you happen to be hovering over them.

A highlight that changes the background color and not the text color would require some forethought to use without turning parts of a page very low contrast. Highlighted text need not be black, as I now offer the full color gamut for both text and background.

It occurred to me to use the alpha channel. That would better simulate the effect of highlighting markers on the printed page, as all the colors of the underlying text would be tinted in the direction of the highlighter color, but color variations would still be there. I haven't done that mainly because it would require a change to the database model and make things more complicated for text passages already highlighted using earlier versions. There are also those edge cases (probably trending to more common) in which websites include alpha channels in text and/or background colors.