search

n8design / htwoo

hTWOo - a better Fluent UI framework.
http://my.n8d.at/hTWOo
MIT License
91 stars 9 forks source link

Command bar height not matching Fluent React #117

Closed gabbsmo closed 3 weeks ago

gabbsmo commented 4 months ago

Describe the bug The height of the command bar is 46px or 48px, with .has-overflow.

To Reproduce Steps to reproduce the behavior:

  1. Go to Pattern Lab
  2. Inspect the height of .hoo-cmdbar

Expected behavior As in Fluent React, where it always is 44px.

Desktop (please complete the following information):

Additional context .hoo-cmdbar has a 1px border transparent border, increasing the height to 46px. With .has-overflow, a slightly bigger min-height is also set, increasing the hight to 48px.

gabbsmo commented 4 months ago

My current workaround:

.hoo-cmdbar {
    border: none;
}

.hoo-cmdbar.has-overflow {
    min-height: inherit;
}
StfBauer commented 1 month ago

🛳️ Shipped in 2.5.0 - https://lab.n8d.studio/htwoo/changelog/htwoo-core-cl/