search

n8design / htwoo

hTWOo - a better Fluent UI framework.
http://my.n8d.at/hTWOo
MIT License
93 stars 9 forks source link

Invalid markup in cmdbar #123

Closed gabbsmo closed 7 months ago

gabbsmo commented 8 months ago

Describe the bug Menu items in cmdbar are a list of div tags. If they are replaced with <li> tags the style is broken with visible list bullets.

To Reproduce Steps to reproduce the behavior:

  1. Go to Pattern Lab
  2. Replace <div> tags under the <menu> tag with <li> tags using DevTools.

Expected behavior As per MDN, menu should be treated similarily to <ul>, and thus should contain <li> tags.

Desktop (please complete the following information):

Additional context Another alternative is to use ARIA role="list", which is the implicit role for <menu>, along with role="listitem".

With that said, I realize the specc is not always the right way from the users perspective. If this was a concious decision, please let me know and why if possible.

StfBauer commented 8 months ago

You are right. Reverted it back to div. I might get refactored in future but not at the moment. Fixing the markup would require a rethinking of the overflow behaviour.

StfBauer commented 7 months ago

Fixed in in 2.4. 0