search

n8felton / Firefox-ADMX

Firefox ADMX is a way of allowing centrally managed locked and/or default settings in Firefox via Group Policy and Administrative Templates in Active Directory. Firefox ADMX is a continuation of Firefox ADM by Mark Sammons.
54 stars 26 forks source link

Support for proxy settings lockdown #17

Closed dlfraga closed 8 years ago

dlfraga commented 8 years ago

I've added support to lockdown proxy settings.

n8felton commented 8 years ago

There are a couple issues with the code as it is right now, mostly just some clean up stuff.

https://github.com/n8felton/Firefox-ADMX/pull/17/files#diff-99ce6a2b8d23e3ecf16981bce519f329L1 https://github.com/n8felton/Firefox-ADMX/pull/17/files#diff-468a9e6b83e5cc2e860a657f6b36f67dL1

You removed the <?xml version="1.0" encoding="utf-8"?> tag at the start, that needs to go back in.

Also, there are few lines in there that have tabs rather than spaces. If you could just convert everything to spaces to be consistent, I'd appreciate it. From the looks of it, you already cleaned up some erroneous extra spacing, thanks for that.

n8felton commented 8 years ago

LGTM