n8henrie / fauxmo

Emulated Belkin WeMo devices that work with the Amazon Echo
https://n8henrie.com/2016/02/fauxmo-home-automation-with-the-amazon-echo-raspberry-pi-and-homeassistant/
Other
371 stars 78 forks source link

Support Wemo Dimmer Switch #104

Closed mocallins closed 4 years ago

mocallins commented 4 years ago

Are you looking at adding other Wemo devices that Raspberry Pi would be able to emulate.

I would think the dimmer switch would be an excellent addition, since it has more functions, to play around with.

Thanks in advance.

i.e. somebody else out there has captured the setup.xml

n8henrie commented 4 years ago

I am not, since I don't have any relevant devices, so I am not particularly motivated, would be unable to ensure my implementation worked, and would be unable to maintain / debug it going forward.

Do you have a link to a reference implementation I could check out? If it fits neatly into the codebase and the contributor were interesting in helping maintain the relevant code going forward, I would accept a PR.

I'll leave this issue open for a little while to see if there are any bites from interested contributors, but otherwise will close it.

mocallins commented 4 years ago

Hmmm i'm not sure if it was a full implementation, i just saw that they had captured the setup.xml

I'll look around again, it was here on github.

mocallins commented 4 years ago

Add support for WeMo Dimmer Light Switch #3632

https://github.com/eclipse-archived/smarthome/issues/3632

mocallins commented 4 years ago

Also as an aside, looking through some of the code, you ever heard of a script/package out there called xml(2|To)dict ,lol ? Just something i found and used in my own testing work (network testing with python), i had done in the past. Makes dealing with xml data much simpler, can just use normal python commands to interrogate , as well as make a response structure, just as easy with dict(2|To)xml.

n8henrie commented 4 years ago

Cool, thanks for the link.

you ever heard of a script/package out there called xml(2|To)dict ,lol ?

While I can manage Python dependencies pretty easily, unfortunately they end up being difficult to deal with for end users, who then need to work about system vs user installs, virtualenvs, conflicting requirements, etc; as a maintainer, I strongly prefer Fauxmo to remain dependency-free.

https://github.com/n8henrie/fauxmo#plugins

Any pre-installed plugins, like the rest of the core Fauxmo code, have no third party dependencies.

mocallins commented 4 years ago

I understand, I basically took over the package and supported it withihn my librariesx, for pretty much the same reason, i think  I found another version of it that someone claimed we needed, but really didn't.So i ended tht discussion by including it, lol Even though it is a package, its not very extensive, that's why i really refer to it as a script.And well afterword its just a part of the library, and internally maintained, lol.

On Saturday, August 29, 2020, 9:55:39 AM CDT, Nathan Henrie <notifications@github.com> wrote:  

Cool, thanks for the link.

you ever heard of a script/package out there called xml(2|To)dict ,lol ?

While I can manage Python dependencies pretty easily, unfortunately they end up being difficult to deal with for end users, who then need to work about system vs user installs, virtualenvs, conflicting requirements, etc; as a maintainer, I strongly prefer Fauxmo to remain dependency-free.

https://github.com/n8henrie/fauxmo#plugins

Any pre-installed plugins, like the rest of the core Fauxmo code, have no third party dependencies.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.