search

n8henrie / homebridge-rcswitch-gpiomem

Integrate your 433 remote switches into homebridge
MIT License
11 stars 3 forks source link

Switch -> Lightbulb #10

Closed jdtsmith closed 7 years ago

jdtsmith commented 7 years ago

This is working well to control Etekcity outlets all over the house (after I boosted my transmitter to 12V; see this link.

A trivial tweak suggestion: I added a config parameter "config.type" that can be "Lightbulb". In this case, a Lightbulb instead of Switch service is created. Not really different, except now I can say "Siri, turn off all my lights", and any RC-controlled lights are included. Happy to send a PR if you are interested.

n8henrie commented 7 years ago

Sweet, please send the PR!

Nate

On Thu, May 4, 2017 at 9:49 PM, jdtsmith notifications@github.com wrote:

This is working well to control Etekcity outlets all over the house (after I boosted my transmitter to 12V; see this link https://www.raspberrypi.org/forums/viewtopic.php?f=37&t=181618&p=1153964#p1153964 .

A trivial tweak suggestion: I added a config parameter "config.type" that can be "Lightbulb". In this case, a Lightbulb instead of Switch service is created. Not really different, except now I can say "Siri, turn off all my lights", and any RC-controlled lights are included. Happy to send a PR if you are interested.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/n8henrie/homebridge-rcswitch-gpiomem/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLYDKOr8ULUksj4FFNtaqLUo0SgMxdOks5r2pw1gaJpZM4NRdzn .

jdtsmith commented 7 years ago

I later realized this isn't at all necessary, since you can edit the detail for any switch and change its "Type" to Light (or Fan) in the Home app, which works just as well (and requires less code ;).

n8henrie commented 7 years ago

Gotcha, sweet.