Added wiringPi as preinstall-dependency

[gismo141]

This automatically installs the needed library and installs the plugin afterwards.

[n8henrie]

Sweet, thanks! Let me give it a shot, likely merge soon.

[n8henrie]

Hmmm, I'm having second thoughts about merging, but open to discussion.

• Seems to work great, thanks again -- I don't know much javascript and didn't realize this was possible.
• This PR should actually be on rcswitch-gpiomem, which is actually what requires wiringPi (and is a dependency of this project) -- depending on the outcome of this conversation, we may need to close / recreate the PR there instead.
• I really don't like the fact that this now requests root privileges to install my library (because wiringPi asks for them, and it's now installed by default).
• I'm not super excited that this installs a second wiringPi instance if you already have it installed separately.

There may be a reasonable workaround -- evaluating if wiringPi is already installed. If not, then attempting to install it is reasonable, since it is a dependency. But if we can reliably detect if it is already installed, then there will be no request for root privileges.

For example, sudo ldconfig -p | grep libwiringPi.so || (install wiringPi here) would probably be a fairly robust way to do this, but then it defeats the purpose by requiring sudo.

I suppose something like if ! command -v /usr/lib/libwiringPi.so; then (install wiringPi here); fi may work, but obviously would make things difficult if people had somehow installed the shared library somewhere else (is that possible?).

My inclination is to keep things simple and just tell people "you have to install wiringPi" -- which lets them do that however they like, is how several similar projects have handled this situation, and if the wiringPi install process changes, I won't have to change anything here to reflect that.

Does my reasoning make sense?

[n8henrie]

Closing due to inactivity

[gismo141]

Sorry for being late, few days ago I started to write a response but somehow I missed to send it.

The thing with the root-rights seems to have something do to where you store the node_modules. During the next days I'll try to reproduce if this happens.

Otherwise I haven't thought about putting it directly into the base-repo - this might be indeed a much better way to do it. As well I'm not quite sure if you could be able to have a different library of wiringpi somewhere else. Normally the linker looks at specific places so it should be possible to narrow down with your hint of looking up the library.

[n8henrie]

No worries. I think the root rights has more to do with the wiringPi installation, which requires root rights (e.g. to install the gpio binary to /usr/local/bin). If you find a way to avoid the root rights requirement, let me know and we could merge into rcswitch-gpiomem.