search

n8henrie / jupyter-black

A simple extension for Jupyter Notebook and Jupyter Lab to beautify Python code automatically using Black. Fork of dnanhkhoa/nb_black.
MIT License
55 stars 3 forks source link

Proposal for removing defensive upper version constraints for transient dependencies #6

Closed JakobGM closed 1 year ago

JakobGM commented 1 year ago

My Issue

Hi, Nathan, thanks for having created this package :bow:

I see that you have put an upper version constraint < 8 on ipython. This package therefore downgrades ipython for any dependents. I was just wondering if there any specific reason for why you have put the version constraint in place or not, is the current implementation incompatible with version 8 of the ipython API, or is it mainly a "defensive" constraint put in place before version 8 was released? :relaxed:

If it is the latter, a defensive upper constraint, might I suggest removing it? I will refer to this great read as my argument for doing so :nerd_face:

Regardless what you decide, thanks in advance!

n8henrie commented 1 year ago

Your points are well taken. This was an experiment with upper version bounds (which I've never used in a project before), I appreciate you pointing out some downsides.

I'll cut a new version soon that should resolve this.

n8henrie commented 1 year ago

Should be resolved in ~0.3.2~ 0.3.3, which if everything passes should get pushed to PyPI by CI.

If you can confirm a fix would you mind closing?

JakobGM commented 1 year ago

That was a quick response, thanks a lot! It works 🎉