search

n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
44.62k stars 5.95k forks source link

Contributing documentation is out of date #10002

Open cgsmith opened 1 month ago

cgsmith commented 1 month ago

Bug Description

The contribution markdown contains the wrong version of Node referenced.

image

To Reproduce

  1. Download n8n repo
  2. Install Node 18.10
  3. Receive error on pnpm install command

Expected behavior

pnpm install should proceed correctly.

Operating System

Pop!_OS 22.04 LTS

n8n Version

1.50.0 (master)

Node.js Version

18.10.0

Database

SQLite (default)

Execution mode

main (default)

cgsmith commented 1 month ago

So my PR #10003 might not be right. When trying pnpm start after pnpm build on node 18.12 it fails saying n8n requires v18.17.0

I think the versions should be bumped to at least 18.17 as a requirement if that is the case.

Joffcom commented 1 month ago

Great spot, as our minimum is 18.17.0 we should probably use that in the docs.

Let me check with the team to confirm.