n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
48.96k stars 7.78k forks source link

Delete Field in Edit Module misbehavior in GUI #10727

Open leesilverman opened 2 months ago

leesilverman commented 2 months ago

Bug Description

When deleting a field in the edit module, the list of remaining fields "scrolls up" by one as expected, but the field that was just deleted remains displayed. If I save and re-open the field was correctly deleted, so this is probably just a GUI issue.

To Reproduce

I tried reproducing this from scratch with a new edit module and was not able to cause the same behavior. But it's happening with an existing module, which I've pasted below.

  1. Copy the code below
  2. Paste into a new workflow canvas in 1.57.0
  3. Open the module and click the trash icon next to "Defensive Driving"
  4. THIS IS WHERE THE ERROR OCCURS: in the GUI, the "Defensive Driving" field still appears to be present.
  5. Click "Back to Canvas" to save
  6. Re-open the module. The "Defensive Driving" field has been deleted as expected.

{ "meta": { "instanceId": "56a3b6e808c84fdadd2d80585289500a7b27625c2792fc6c214518fe7ce0a003" }, "nodes": [ { "parameters": { "assignments": { "assignments": [ { "name": "Contract Number", "value": "={{ $json.q64_CN }}", "type": "string" }, { "name": "Registration Date", "value": "={{ DateTime.fromMillis(parseInt($json.buildDate)).setZone('America/New_York').toISODate() }}", "type": "string" }, { "name": "30 Hr Classroom", "value": "={{ $json.q24_typeOfInst.includes('30 Hour Classroom') }}", "type": "boolean" }, { "name": "Behind the Wheel", "value": "={{ $json.q24_typeOfInst.includes('Behind the Wheel') }}", "type": "boolean" }, { "name": "Driver Improvement", "value": "={{ false }}", "type": "boolean" }, { "name": "Drivers Test", "value": "={{ $json.q24_typeOfInst.includes('Drivers License Test') }}", "type": "boolean" }, { "name": "Behind the Wheel Hrs", "value": "={{ parseInt($json.q29_btw_hours) }}", "type": "number" }, { "name": "Defensive Driving", "value": "={{ false }}", "type": "boolean" }, { "name": "DI/DD Intent", "value": "={{ null }}", "type": "string" }, { "name": "Student DOB", "value": "={{ $json.q49_studentDOB.datetime.split(\" \")[0] }}", "type": "string" }, { "name": "Student Fullname", "value": "={{ $json.q2_name }}", "type": "string" }, { "name": "Student Email", "value": "={{ $json.q75_studentEmail }}", "type": "string" }, { "name": "Student Phone", "value": "={{ $json.q53_studentPhone.full }}", "type": "string" }, { "name": "Parent Fullname", "value": "={{ $json.q74_parentName }}", "type": "string" }, { "name": "Parent Email", "value": "={{ $json.q76_parentEmail }}", "type": "string" }, { "name": "Parent Phone", "value": "={{ $json.q54_parentPhone.full }}", "type": "string" }, { "name": "Drivers License or Permit", "value": "={{ $json.q84_studentHas == \"Valid Driver's License\" ? \"License\" : $json.q84_studentHas == \"Valid Learner's Permit\" ? \"Permit\" : \"None\" }}", "type": "string" }, { "name": "License/Permit Number", "value": "={{ $json.q12_dlno }}", "type": "string" }, { "name": "License/Permit Expiration", "value": "={{ $json.q55_studentLicense.datetime.split(\" \")[0] }}", "type": "string" } ] }, "options": {} }, "id": "718bb259-3569-4d4d-a820-bf21e9d885da", "name": "Set Sheets Variables: V6 STUDENT UNDER 18 DRIVING SCHOOL AGREEMENT", "type": "n8n-nodes-base.set", "typeVersion": 3.4, "position": [ 920, -160 ] } ], "connections": {}, "pinData": {} }

Expected behavior

When you delete a field the remaining fields should scroll up to replace.

Operating System

Ubuntu Linux 24

n8n Version

1.57.0

Node.js Version

18.19.1

Database

PostgreSQL

Execution mode

main (default)

Joffcom commented 2 months ago

Hey @leesilverman,

We have created an internal ticket to look into this which we will be tracking as "GHC-211"