n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
46.5k stars 6.68k forks source link

Empty RSS Feed cause error on RSS Feed Trigge #10853

Closed bjacquemet closed 2 weeks ago

bjacquemet commented 2 weeks ago

Bug Description

When using a RSS Feed Trigger, if the RSS feed doesn't have entries, then the workflow can't be activated.

Example of an empty RSS feed:

<feed xmlns="http://www.w3.org/2005/Atom" xmlns:idx="urn:atom-extension:indexing">
<id>tag:google.com,2005:reader/user/14265068296652275629/state/com.google/alerts/1327531161528255741</id>
<title>Google Alert - techcrunch travel startup</title>
<link href="https://www.google.com/alerts/feeds/14265068296652275629/1327531161528255741" rel="self"/>
</feed>

A good one would have <entry> nodes.

Example with only one node in the worfklow: image

The issue might be coming from this line as items can be empty.

To Reproduce

  1. Go to your canvas
  2. Add a RSS Feed trigger
  3. Set the url to an empty google alerts (for example). At the time of writing, this alert is empty
  4. Test the workflow (it runs successfully)
  5. Save (it works successfully)
  6. Try activating the workflow -> It fails.

Expected behavior

You should be able to activate the workflow

Operating System

Ubuntu 23.0.6

n8n Version

1.57.0

Node.js Version

unknown

Database

SQLite (default)

Execution mode

main (default)

Joffcom commented 2 weeks ago

Hey @bjacquemet,

We have created an internal ticket to look into this which we will be tracking as "GHC-241"