search

n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
45.88k stars 6.42k forks source link

Todoist node always returns Success without checking server response #10914

Open umanamente opened 6 hours ago

umanamente commented 6 hours ago

Bug Description

In the Todoist node, the server response is not properly checked when executing commands. The issue is that the node always returns Success: true, even when the server response might indicate failure or error.

For example: https://github.com/n8n-io/n8n/blob/769ddfdd1d6d5620757c67fb36520dcefb324937/packages/nodes-base/nodes/Todoist/v2/OperationHandler.ts#L269-L271

To Reproduce

  1. Use the Todoist node in a workflow.
  2. Execute a Todoist-related command (e.g., move a task).
  3. Regardless of the actual server response, the node will return Success: true.

Expected behavior

The response from the Todoist API should be validated to ensure that the success status is accurate.

Operating System

Any

n8n Version

1.59.4

Node.js Version

20.17.0

Database

PostgreSQL

Execution mode

main (default)

Joffcom commented 6 hours ago

Hey @umanamente,

We have created an internal ticket to look into this which we will be tracking as "GHC-247"