Wrong End Date output for all-day events with "Convert to ICS"

[jpbaril]

Bug Description

The Convert to File Node (Convert to ICS) output "end date" for all-day events is wrong, it's one day later than what it should. E.g. Christmas: DTSTART;VALUE=DATE:20241225 DTEND;VALUE=DATE:20241227

To Reproduce

1. Use node "Convert to File".
2. Fill in fields.
3. Look at output file.

Expected behavior

To have correct end date, i.e. end date to be 1 day earlier.

Operating System

docker (self-hosted)

n8n Version

1.63.0

Node.js Version

20.18.0

Database

SQLite (default)

Execution mode

main (default)

[Joffcom]

Hey @jpbaril,

We have created an internal ticket to look into this which we will be tracking as "GHC-302"

[Joffcom]

Hey @jpbaril

It looked ok when I tested it but I may have missed all day event.

What timezone and tz env option do you have set at the moment?

[jpbaril]

Hey @jpbaril

It looked ok when I tested it but I may have missed all day event.

What timezone and tz env option do you have set at the moment?

  - GENERIC_TIMEZONE=America/Toronto
  - TZ=America/Toronto

[Joffcom]

Hey @jpbaril,

I did put in a "fix" for this but when testing what we have now and importing the outputted cal event into different systems it showed the correct dates so it looks like this may actually be ok.

Are you using the ICS file in a calander or do you always manually parse them?

[jpbaril]

Are you using the ICS file in a calander or do you always manually parse them?

I'm not sure to understand (as English is not my main language).

[jpbaril]

My_workflow.json event.ics.txt

Debug info

core

• n8nVersion: 1.63.0
• platform: docker (self-hosted)
• nodeJsVersion: 20.18.0
• database: sqlite
• executionMode: regular
• concurrency: -1
• license: enterprise (production)
• consumerId: 1f3e417e-92e0-4faf-9d1f-40d542cb15de

storage

• success: all
• error: all
• progress: false
• manual: true
• binaryMode: memory

pruning

• enabled: true
• maxAge: 336 hours
• maxCount: 10000 executions

Generated at: 2024-10-13T09:23:19.921Z

[jpbaril]

BTW, if event is not an all-day event then resulting end date is ok.

[Joffcom]

@jpbaril how do you normally use the ICS files? When testing the current dates in a few different calendar applications they load as expected.