n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
49.52k stars 7.98k forks source link

fix(editor): Turn NPS survey into a modal and make sure it shows above the Ask AI button #11814

Closed RicardoE105 closed 4 days ago

RicardoE105 commented 5 days ago

Summary

Before

https://share.cleanshot.com/pxrLdfTX

Now

CleanShot 2024-11-20 at 18 07 26

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2914/bug-how-likely-to-recommend-survey-blocking-everything

Review / Merge checklist

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review. Files with missing lines Patch % Lines
packages/editor-ui/src/components/NpsSurvey.vue 0.00% 5 Missing :warning:
packages/editor-ui/src/components/ModalDrawer.vue 0.00% 2 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

cypress[bot] commented 4 days ago

n8n    Run #8028

Run Properties:  status check passed Passed #8028  •  git commit 633e4166df: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review ado-2914-bug-how-likely-to-recommend-survey-blocking-everything
Run status status check passed Passed #8028
Run duration 04m 38s
Commit git commit 633e4166df: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎
github-actions[bot] commented 4 days ago

:white_check_mark: All Cypress E2E specs passed