Closed netroy closed 4 hours ago
Attention: Patch coverage is 45.65217% with 50 lines in your changes missing coverage. Please review. |
Files with missing lines | Patch % | Lines |
---|---|---|---|
.../src/node-execution-context/supply-data-context.ts | 44.18% | 48 Missing :warning: | |
packages/core/src/NodeExecuteFunctions.ts | 33.33% | 2 Missing :warning: |
:loudspeaker: Thoughts on this report? Let us know!
Passed #8050
•
4bed795a75: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project |
n8n
|
Branch Review |
CAT-311-extract-supply-data-context
|
Run status |
Passed #8050
|
Run duration | 04m 29s |
Commit |
4bed795a75: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
|
Committer | कारतोफ्फेलस्क्रिप्ट™ |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
478
|
View all changes introduced in this branch ↗︎ |
:white_check_mark: All Cypress E2E specs passed
Summary
This PR extracts SupplyDataContext object out of NodeExecutionFunctions, and adds unit tests for most of this code.
Related Linear tickets, Github issues, and Community forum posts
CAT-311
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)