n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
49.29k stars 7.89k forks source link

refactor(core): Extract SupplyDataContext out of NodeExecutionFunctions (no-changelog) #11834

Closed netroy closed 4 hours ago

netroy commented 1 day ago

Summary

This PR extracts SupplyDataContext object out of NodeExecutionFunctions, and adds unit tests for most of this code.

Related Linear tickets, Github issues, and Community forum posts

CAT-311

Review / Merge checklist

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 45.65217% with 50 lines in your changes missing coverage. Please review. Files with missing lines Patch % Lines
.../src/node-execution-context/supply-data-context.ts 44.18% 48 Missing :warning:
packages/core/src/NodeExecuteFunctions.ts 33.33% 2 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

cypress[bot] commented 4 hours ago

n8n    Run #8050

Run Properties:  status check passed Passed #8050  •  git commit 4bed795a75: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review CAT-311-extract-supply-data-context
Run status status check passed Passed #8050
Run duration 04m 29s
Commit git commit 4bed795a75: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎
github-actions[bot] commented 4 hours ago

:white_check_mark: All Cypress E2E specs passed