n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
50.42k stars 8.2k forks source link

Webhooks failing after updating to ver 1.70.0 #11962

Closed Toolfolks closed 3 hours ago

Toolfolks commented 3 days ago

Bug Description

{ "errorMessage": "Cannot read properties of undefined (reading 'getNode')", "errorDetails": {}, "n8nDetails": { "n8nVersion": "1.70.0 (Self Hosted)", "binaryDataMode": "default", "stackTrace": [ "TypeError: Cannot read properties of undefined (reading 'getNode')", " at WebhookContext.webhook (C:\Users\sales\AppData\Roaming\npm\node_modules\n8n-nodes-base\nodes\Webhook\Webhook.node.ts:182:64)", " at Workflow.runWebhook (C:\Users\sales\AppData\Roaming\npm\node_modules\n8n\node_modules\n8n-workflow\src\Workflow.ts:1265:29)", " at Object.executeWebhook (C:\Users\sales\AppData\Roaming\npm\node_modules\n8n\src\webhooks\webhook-helpers.ts:258:39)", " at processTicksAndRejections (node:internal/process/task_queues:95:5)", " at C:\Users\sales\AppData\Roaming\npm\node_modules\n8n\src\webhooks\test-webhooks.ts:117:25" ] } }

To Reproduce

I have a webhook trigger - mysql - response to webhook

Expected behavior

Passes a parameter to mysql and returns the result.

Operating System

win 10

n8n Version

1.70.0

Node.js Version

10.8.2

Database

SQLite (default)

Execution mode

main (default)

Joffcom commented 3 days ago

Hey @Toolfolks,

We have created an internal ticket to look into this which we will be tracking as "GHC-526"

netroy commented 3 days ago

Do you have any community nodes installed?

Toolfolks commented 3 days ago

No

Toolfolks commented 2 days ago

FYI I have downgraded to 1.68.0 ( where it was working ) It now fails.

netroy commented 2 days ago

Can you check if there are any files in the .n8n/nodes folder? On Windows I'm guessing it should be C:\Users\sales\.n8n\nodes

Toolfolks commented 2 days ago

The only file I have is C:\sales.n8n\node_modules.pakacge-lock.json

There is no nodes folder

On 29 Nov 2024, at 17:58, कारतोफ्फेलस्क्रिप्ट™ @.***> wrote:

Can you check if there are any files in the .n8n/nodes folder? On Windows I'm guessing it should be C:\Users\sales.n8n\nodes

— Reply to this email directly, view it on GitHub https://github.com/n8n-io/n8n/issues/11962#issuecomment-2508214628, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5Z5JOVJPH5ENW5VQTNMUGT2DCTM3AVCNFSM6AAAAABSVYIAICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYGIYTINRSHA. You are receiving this because you were mentioned.

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/n8n-io/n8n/issues/11962#issuecomment-2508214628", "url": "https://github.com/n8n-io/n8n/issues/11962#issuecomment-2508214628", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

netroy commented 3 hours ago

So far I'm not able to reproduce this. But I have a suspicion that the issue is in your npm installation. For example, if n8n was install via npm -g install n8n, node_modules\n8n-nodes-base should actually have been node_modules\n8n\node_modules\n8n-nodes-base, and there shouldn't be a node_modules\n8n\src folder.

What's likely happening here is that you have multiple copies of the n8n-workflow package in your setup, and that is leading to some instanceof checks failing in JS, because there are multiple copies of certain classes, where there should have only been one.

Unless you are developing n8n, my recommendation would be to delete your current installation, and install via npm -g install n8n instead. If you are developing on the source code, then I think you should look into setting up the repo as documented in the contribution guide, to ensure that all packages are linked correctly.

Since this is not a supported installation type, I think we should close this issue, and move the discussion to community.n8n.io.

netroy commented 3 hours ago

If this is a standard installation, please let us know, and we can open this ticket again.