n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
47.46k stars 7.14k forks source link

Todoist: Move task requires a section ID #7478

Closed cohan closed 2 weeks ago

cohan commented 1 year ago

Describe the bug

When using a Todoist "Move a task" node, the section ID value is a required field in n8n, however this field is not required in the Todoist API. Leaving it blank gives a validation error: The value "" is not supported!

Unfortunately none of the tasks I want to move have a section to be moved into.

To Reproduce

Steps to reproduce the behavior:

Try to use the Todoist "Move a task" node in a workflow. Try to leave the section ID blank.

Expected behavior

I'd expect a blank field to be supported in this case - if the section ID is blank it doesn't need sending to the Todoist API. This would allow me to move a task into the base project rather than a section within it.

Environment (please complete the following information):

Additional context

Todoist API doc: https://developer.todoist.com/sync/v9/#move-an-item

API call is in packages/nodes-base/nodes/Todoist/v2/OperationHandler.ts

Somewhat difficult to debug, looks like some of the Todoist nodes return "success: true" no matter what happens during the API call.

Joffcom commented 1 year ago

Hey @cohan,

Thanks for the report it looks like the Move operation could do with some love as there are 3 optional fields, I have created NODE-874 as our internal ticket to update this.

cohan commented 1 year ago

Awesome, cheers!

janober commented 2 weeks ago

Fix got released with n8n@1.62.1