n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
45.77k stars 6.39k forks source link

Salesforce Node - URI Format Issue #886

Closed camcelroy closed 4 years ago

camcelroy commented 4 years ago

https://github.com/n8n-io/n8n/blob/master/packages/nodes-base/nodes/Salesforce/GenericFunctions.ts

The salesforceApiRequest method builds a URI of the format .salesforce.com. Salesforce environments which have been setup recently using "My Domain" should instead be built as .my.salesforce.com. Documentation from Salesforce reflecting this is outlined at https://help.salesforce.com/articleView?id=domain_name_app_url_changes.htm&type=5

Our corporate Salesforce instance is configured in this way, and as such the .salesforce.com generated URI does not work.

I have worked around this by customizing my local Salesforce node, but an integrated solution would be best.

Similarly, a tip or doc for the Salesforce Salesforce OAuth2 API credentials noting the needed format for the Access Token URL would be helpful.

Screen Shot 2020-08-25 at 6 36 56 PM

RicardoE105 commented 4 years ago

@camcelroy Thanks for letting us know about this issue. Will add it to the backlog and keep you posted. With regard to the documentation, we are continually improving it. Hopefully, we will have a 'how to get the credentials soon'

RicardoE105 commented 4 years ago

Looks like this PR from a community member will fix the issue you are having. Can you confirm? @camcelroy

camcelroy commented 4 years ago

@RicardoE105 Confirmed.

RicardoE105 commented 4 years ago

@camcelroy thanks.

janober commented 4 years ago

Thanks a lot @YEriin for the fix!

Just got released with n8n@0.79.0