refactor: Fix TypeScript errors workflow package - Githubissues

n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.

https://n8n.io

Other

41.62k stars 5.27k forks source link

refactor: Fix TypeScript errors workflow package #9437

Closed elsmr closed 2 weeks ago

elsmr commented 2 weeks ago

Summary

Replaced @/ imports in workflow package with relative imports (they conflict with @/ imports in editor-ui
- Tried changing the tsconfig and using https://www.npmjs.com/package/vite-tsconfig-paths, but it doesn't work. Long thread about it here: https://github.com/vercel/turbo/discussions/620
- Potentially we could use globally unique aliases @ -> @editor-ui, @ -> @workflow but it would be a bigger refactor

Related tickets and issues

https://www.notion.so/n8n/TS-Spring-Cleaning-b41b52e5e79042449b92fabd37b6f77d

Review / Merge checklist

[ ] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
[ ] Docs updated or follow-up ticket created.
[ ] Tests included.

A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

cypress[bot] commented 2 weeks ago

Passing run #5007 ↗︎

0

360

12

0

0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n	Commit: `84ad6a480f`
Status: Passed	Duration: 04:13 💡
Started: May 17, 2024 9:12 AM	Ended: May 17, 2024 9:16 AM

Review all test suite changes for PR #9437 ↗︎

github-actions[bot] commented 2 weeks ago

:white_check_mark: All Cypress E2E specs passed

janober commented 1 week ago

Got released with n8n@1.43.0