fix(editor): Fix i18n translation addition

n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.

https://n8n.io

Other

41.62k stars 5.27k forks source link

fix(editor): Fix i18n translation addition #9451

Closed cstuncsik closed 2 weeks ago

cstuncsik commented 2 weeks ago

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

[x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
[x] Docs updated or follow-up ticket created.
[x] Tests included.

A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

cypress[bot] commented 2 weeks ago

1 flaky test on run #5026 ↗︎

361

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n	Commit: `2f01c1f9a2`
Status: Passed	Duration: 04:21 💡
Started: May 17, 2024 3:11 PM	Ended: May 17, 2024 3:15 PM

cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
NDV > should not retrieve remote options when required params throw errors		`Screenshots` `Video`

Review all test suite changes for PR #9451 ↗︎

github-actions[bot] commented 2 weeks ago

:white_check_mark: All Cypress E2E specs passed

janober commented 1 week ago

Got released with n8n@1.43.0