n8n-io / n8n

Free and source-available fair-code licensed workflow automation tool. Easily automate tasks across different services.
https://n8n.io
Other
41.62k stars 5.27k forks source link

fix(core): Setup webhook stopping endpoint after the CORS middleware (no-changelog) #9454

Closed netroy closed 2 weeks ago

netroy commented 2 weeks ago

This endpoint needs to be setup after the CORS middleware to make it work in dev mode.

Slack conversation.

Review / Merge checklist

github-actions[bot] commented 2 weeks ago

:white_check_mark: All Cypress E2E specs passed

cypress[bot] commented 2 weeks ago

3 flaky tests on run #5028 ↗︎

0 361 12 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 8f1959dbb4
Status: Passed Duration: 04:46 💡
Started: May 17, 2024 3:48 PM Ended: May 17, 2024 3:53 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests View Output Video
Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  39-projects.cy.ts • 1 flaky test View Output Video
Test Artifacts
Projects > should handle workflows and credentials Test Replay Screenshots Video

Review all test suite changes for PR #9454 ↗︎

janober commented 1 week ago

Got released with n8n@1.43.0