search

n8nhackers / n8n-nodes-document-generator

This node renders Handlebars templates for documents or emails
MIT License
25 stars 7 forks source link

Not using jaredwray/fumanchu (handlebars+handlebars-helpers) #8

Open washcroft opened 3 months ago

washcroft commented 3 months ago

Although you've switched the dependency to jaredwray/fumanchu to take advantage of bundled handlebars-helpers, you're still referencing the core handlebars package here so the helpers aren't being loaded:

https://github.com/n8nhackers/n8n-nodes-document-generator/blob/cee45c63a2b31b4c998ffeabc75dd313e59eac5c/nodes/DocumentGenerator/DocumentGenerator.node.ts#L1

Compared to the @aprosvetova fork:

https://github.com/aprosvetova/n8n-nodes-document-generator/blob/915e01b872b81556d69038da79357fbdd09a1429/nodes/DocumentGenerator/DocumentGenerator.node.ts#L1

import * as Handlebars from '@jaredwray/fumanchu';