search

n8willis / opentype-shaping-documents

Documentation of OpenType shaping behavior
170 stars 13 forks source link

Fixes to Syriac shaping #107

Closed alfiedotwtf closed 2 years ago

alfiedotwtf commented 3 years ago

There are a few comments here, but I also need to integrate some suggested changes made by the not-on-GitHub Syriac contact I talked to. Might be preferable to let me integrate those, then rebase this PR on that.

I think it will be easier if I restart this PR once your changes have been included.

alfiedotwtf commented 2 years ago

I think it will be easier if I restart this PR once your changes have been included.

Rebased the previous changed on top of head. Let me know if you need anything changed :)

n8willis commented 2 years ago

OK. I went back and forth a bit on whether to re-edit the whole joining-state algorithm block into a numbered list, which would probably make it a lot clearer to read than the Markdown-bulleted version (even within the same markdown renderer). I'll test that quickly, but I did not want to hold this up any longer than it has been waiting so far. Thanks for sticking with this!

alfiedotwtf commented 2 years ago

Sorry for the such long delay on this one, but thanks for the merge.