nE0sIghT / vortex-overlay

Gentoo Vortex overlay
15 stars 4 forks source link

new s25rttr-9999 ebuild #14

Closed stefson closed 8 years ago

stefson commented 8 years ago

The s25rttr live ebuild in the overlay is outdated and not compiling right now. I tried to work it out, but do not have any clue how to do this.

It seems as if the s25rttr-9999-boost.patch can be deleted due to commit b7b2f4fe1301c10acec98b87712029c046aa38e5

thanks :)

nE0sIghT commented 8 years ago

I need to bump boost to 1.58 to check this issue. That will take some time

stefson commented 8 years ago

If I haven't got anything wrong the guys at s25rttr added a backport to support boost 1.55 till 1.58 a few months ago? Have a look at s25client/contrib/backport

stefson commented 8 years ago

thank you for the fast response. however, there are a few warnings during src_prepare

CMake Warning at CMakeLists.txt:274 (message): Directory '/var/tmp/portage/games-strategy/s25rttr-9999-r2/work/s25rttr-9999/S2' missing! Call Stack (most recent call first): CMakeLists.txt:284 (symlinkFolder)

and also complaining about The dependency target "updateversion" of target "audiodrv" does not exist , which goes for videodrv, videoSDL, audioSDL and s25client as well.

plus the following fatal error: boost/endian/conversion.hpp: No such file or directory during compile. These headers are to be found in the contrib/boost-1.56-1.58 folder.

nE0sIghT commented 8 years ago

Which version of boost do you have?

stefson commented 8 years ago

I am using system-boost 1.56 the last version I was able to compile is bd3f7ccd8e042a3d7bdfbaa9b1f1fbfe3ab372d1 which is one week old.

nE0sIghT commented 8 years ago

Actually, 9999 ebuild requires boost-1.58 since september 2015 because provided by upstream backports didn't works for me early with boost 1.55. I rechecked now with boost 1.56 and it looks fine. Try to update overlay and rebuild s25rttr

stefson commented 8 years ago

It compiles on recent master branch.

However there are two things which may be an issue. The cmake build script creates some symlinks, see here https://github.com/Return-To-The-Roots/s25client/blob/master/CMakeLists.txt#L274

which throws out the following error CMake Warning at CMakeLists.txt:274 (message): Directory '/var/tmp/portage/games-strategy/s25rttr-9999-r2/work/s25rttr-9999/S2' missing! Call Stack (most recent call first): CMakeLists.txt:284 (symlinkFolder)

and I guess related to the same lines of code is the warning of Policy CMP0046 not being set. see here https://bpaste.net/show/9589b5f56d52

Is that something upstream has to deal with? Or is it Gentoo specific?

nE0sIghT commented 8 years ago

There is 2 warnings as i see:

  1. Because of gentoo-specific patch that removes updateversion component. We can drop this patch partially if upstream makes version update/git stuff optional.
  2. As for folders symlinks - I do not really understand why that stuff exists in cmake. You can safelly ignore that warning.
stefson commented 8 years ago

Thank you for explaining, I will close now as the compile issues are solved :+1: