search

nExtendSoftware / rsocket-broker-client-js

RSocket broker client implementation to be used in conjunction with RSocket broker
Apache License 2.0
0 stars 0 forks source link

refactor package type='module' instead of 'commonjs' #1

Open veltmanj opened 1 year ago

veltmanj commented 1 year ago

In angular node type modules 'commonjs' need to be registered separately in the projects descriptions.

"allowedCommonJsDependencies": [ "rsocket-broker-client-js" ],

It would be nice if we can avoid this by making the package type 'module'.

veltmanj commented 1 year ago

Partial 'succes' version 0.0.19 now rsocket-broker-client-js dependencies to be registered.

"allowedCommonJsDependencies": [ "buffer","rsocket-adapter-rxjs","rsocket-core","rsocket-websocket-client","rsocket-composite-metadata" ],

Although the imports are more aligned,

import {BrokerClientId, BrokerRoutingType, Tags, WellKnownKey, ConnectionProperties, RequestProperties} from "rsocket-broker-client-js";

Having 5 items to register instead of one is not an improvement. Version 0.0.6 is therefore still preferable.

Need to investigate further to see if this can be fixed.