Fix for getStructureName for finding group objects by short name.

nHapiNET / nHapi

nHapi is the .Net port of the original Java project HAPI.

Mozilla Public License 2.0

277 stars 156 forks source link

Fix for getStructureName for finding group objects by short name. #190

Closed cs4jx86 closed 3 years ago

cs4jx86 commented 3 years ago

This fixes failing AddORDER() and GetORDER() function calls for group objects. Example message item VXU_V04 has VXU_V04_ORDER and VXU_V04_PATIENT which are found by ORDER and PATIENT respectively. This will fix all versions.

github-actions[bot] commented 3 years ago

Unit Test Results

    5 files   54 suites 8s :stopwatch: 406 tests 139 :heavy_check_mark: 2 :zzz: 265 :x: 810 runs 277 :heavy_check_mark: 3 :zzz: 530 :x:

For more details on these failures, see this check.

Results for commit e6b6c37a.

milkshakeuk commented 3 years ago

@cs4jx86 just out of curiosity, why did you close this PR?

cs4jx86 commented 3 years ago

I apologize for sending this pull request early. If possible can it be deleted? I put the fix I found on issue #59 that did not require coding changes. I was attempting to fix the AbstractGroup.getStructureName from the NHapi.Base so it could find custom structures but overriding GetStructureName was enough.

milkshakeuk commented 3 years ago

@cs4jx86 thanks for adding the solution to #59 does that mean it could be closed? Don't worry about creating the PR, it can't be deleted but its closed so it's fine.

cs4jx86 commented 3 years ago

I would hope someone else could verify first, but otherwise I was able to generate the message with that change.