Closed milkshakeuk closed 2 years ago
5 files 106 suites 21s :stopwatch: 1 051 tests 1 045 :heavy_check_mark: 6 :zzz: 0 :x: 2 007 runs 1 996 :heavy_check_mark: 11 :zzz: 0 :x:
Results for commit 8444f418.
@milkshakeuk I should be able to take a look this weekend.
Should CHANGELOG.md
also be updated?
5 files 106 suites 24s :stopwatch: 1 051 tests 1 045 :heavy_check_mark: 6 :zzz: 0 :x: 2 007 runs 1 996 :heavy_check_mark: 11 :zzz: 0 :x:
Results for commit 09b0e34c.
Should
CHANGELOG.md
also be updated?
I have updated it, I usually do this as prep for a new release but it shouldn't hurt to do it as we go along.
Should
CHANGELOG.md
also be updated?I have updated it, I usually do this as prep for a new release but it shouldn't hurt to do it as we go along.
Out of curiosity, when is the next release planned?
@IanGralinski-Invetech I would like to port one more configuration from hapi before the next release, I don't suppose you would be interested, it's pretty small and some of the code already exists but is commented out in nHapi.
It's the UnexpectedSegmentBehaviour, there is already some commented out code in the MessageIterator ready to use the configuration/option, and here is the hapi implementation of its usage.
@milkshakeuk I could have a go at porting the UnexpectedSegmentBehaviour
option from hapi, though I think I will only get the time to do so late this month, just before the end of the year.
@IanGralinski-Invetech okay I might pick it up then.
Improves on changes made in this commit;
@IanGralinski-Invetech Could you take a look also, if you get chance?