search

nHapiNET / nHapi

nHapi is the .Net port of the original Java project HAPI.
Mozilla Public License 2.0
273 stars 155 forks source link

Remove max repetition check, fixes #276 keeps nhapi in line with hapi #277

Closed milkshakeuk closed 2 years ago

milkshakeuk commented 2 years ago

fixes #276.

Seems that hapi doesn't do the max repetition check, I tested removing this check in nhapi and it prevents the exception also no other tests fail.

Looks like hapi had the max repetition check in the code base but commented out until this commit on 6 Aug 2012 when they just removed the commented out max repetition check altogether.

github-actions[bot] commented 2 years ago

Unit Test Results

       5 files     106 suites   23s :stopwatch: 1 059 tests 1 053 :heavy_check_mark:   6 :zzz: 0 :x: 2 023 runs  2 012 :heavy_check_mark: 11 :zzz: 0 :x:

Results for commit 7bbdbf1e.

github-actions[bot] commented 2 years ago

Unit Test Results

       5 files     106 suites   25s :stopwatch: 1 060 tests 1 054 :heavy_check_mark:   6 :zzz: 0 :x: 2 025 runs  2 014 :heavy_check_mark: 11 :zzz: 0 :x:

Results for commit 42ee1579.

milkshakeuk commented 2 years ago

@AMCN41R can you review?

github-actions[bot] commented 2 years ago

Unit Test Results

       5 files     106 suites   22s :stopwatch: 1 060 tests 1 054 :heavy_check_mark:   6 :zzz: 0 :x: 2 025 runs  2 014 :heavy_check_mark: 11 :zzz: 0 :x:

Results for commit 91ff36f4.