nHapiNET / nHapi

nHapi is the .Net port of the original Java project HAPI.
Mozilla Public License 2.0
272 stars 155 forks source link

Review `ParserBase` member access modifiers to ensure they match those in `hapi`. #399

Open milkshakeuk opened 1 year ago

milkshakeuk commented 1 year ago

Describe the Issue It's not clear that the access modifiers in the ParserBase and any class that inherits from it are using the correct access modifiers for all its members.

I suspect there are some public members which shouldn't be public, I suspect that during the original porting process looking at the default access modifiers for java wasn't compared to the default access modifiers for C#, since these are slightly different.

This issue is just to review those modifiers to make sure they match - it may mean a change in contract which may mean a major nHapi revision.