search

nLabs-nScope / nLab

GNU General Public License v3.0
9 stars 2 forks source link

Trigger time should be moved later in the sweep to capture more pre-trigger time #45

Open michaelpeshkin opened 1 year ago

michaelpeshkin commented 1 year ago

Trigger, need some on-face indication of which trace is connected to trigger. Best, the “T” tab color should match the selected channel, and it would be good if the up/down arrow were repeated there too: T↑ or T↓. Dotted line, white is good, but something that doesn’t get hidden behind a channel trace. Hatched? Also, can you move the trigger-time from one-div to two-div? I agree it does not need to be adjustable, that’s occasionally useful but not worth the complexity.

davidjmeyer commented 1 year ago

Added the channel color to trigger flag as part of #44. Trigger time seems limited to one div on nScope v1, so we'll need to look at firmware changes for that.

Is it really preferable that the trigger dotted lines are drawn on top of the scope traces?

davidjmeyer commented 1 year ago

Ah, yes it actually looks much clearer with the trigger-lines on top, but thinner. Done as part of #52