search

nRF24 / CircuitPython_nRF24L01

CircuitPython driver library for the nRF24L01 transceiver.
http://circuitpython-nrf24l01.rtfd.io/
MIT License
45 stars 11 forks source link

corrected is_plus_variant check when setting data_rate #27

Closed bhartung closed 3 years ago

bhartung commented 3 years ago

fix faulty logic in if self.is_plus_variant statement when setting RF data rate to 250 kbps

2bndy5 commented 3 years ago

Good catch! I rarely test this data rate before release. There's also a bug in __init__() that isn't obvious (I fixed it in my dev branch already). Current release may not be returning accurate data about is_plus_variant (hint: it has something to do with SPI _reg_write() function).

2bndy5 commented 2 years ago

I'm going to remove this check all together

It seems that the datasheet for the plus-variant models don't document how to configure the radio for 250 kbps while the non-plus variants' datasheet does document 250 kbps. Furthermore, there are other radio's out there that do support the 250kbps data rate despite the fact that they claim to be compliant with the plus-variants datasheet.