nRF24 / CircuitPython_nRF24L01

CircuitPython driver library for the nRF24L01 transceiver.
http://circuitpython-nrf24l01.rtfd.io/
MIT License
45 stars 11 forks source link

Fix level 2 child node address handling #49

Closed Hypecta closed 1 year ago

Hypecta commented 1 year ago

Referencing the issue I made in #48 , this should fix the level 2 child node address handling when getting a mesh address response from the master or parent node.

codecov[bot] commented 1 year ago

Codecov Report

Merging #49 (19e9fc9) into master (3d3bc01) will not change coverage. Report is 1 commits behind head on master. The diff coverage is 0.00%.

:exclamation: Current head 19e9fc9 differs from pull request most recent head bafbc17. Consider uploading reports for the commit bafbc17 to get more accurate results

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files          16       16           
  Lines        2465     2465           
=======================================
  Hits         2142     2142           
  Misses        323      323           
Files Changed Coverage Δ
circuitpython_nrf24l01/rf24_mesh.py 37.91% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

2bndy5 commented 1 year ago

CI has failed the linter checks. This is because you left long lines of commented out debug statements. I merged the docs build fix to master, so that CI job should pass when you rebase your branch.

Please remove those debugging lines and rebase your branch on this repo's on master branch.

2bndy5 commented 1 year ago

48 was resolved by #50 for better execution efficiency.