nRF24 / RF24Audio

Arduino library for streaming data/audio from analog inputs via NRF24L01 modules
http://nrf24.github.io/RF24Audio
262 stars 88 forks source link

fix it (ADCSRB | ADTS bits) #23

Closed payamsbr closed 5 years ago

payamsbr commented 5 years ago

in line 580, you commented that adc auto trigger is set on TIMER1 Capture interrupt flag. it require ADTS[2:0] to set 1 but in the code you just set ADTS0 twice. please tell if the code is ok and comment need to be updated. tnx

ADCSRB |= _BV(ADTS0) | _BV(ADTS0) | _BV(ADTS2); //Attach ADC start to TIMER1 Capture interrupt flag

TMRh20 commented 5 years ago

I think it should work like it is, but the code should be corrected.

On Jul 10, 2019, at 06:58, payamsbr notifications@github.com wrote:

in line 580, you commented that adc auto trigger is set on TIMER1 Capture interrupt flag. it require ADTS[2:0] to set 1 but in the code you just set ADTS0 twice. please tell if the code is ok and comment need to be updated. tnx

ADCSRB |= _BV(ADTS0) | _BV(ADTS0) | _BV(ADTS2); //Attach ADC start to TIMER1 Capture interrupt flag

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

payamsbr commented 5 years ago

I think it should work like it is, but the code should be corrected. On Jul 10, 2019, at 06:58, payamsbr @.***> wrote: in line 580, you commented that adc auto trigger is set on TIMER1 Capture interrupt flag. it require ADTS[2:0] to set 1 but in the code you just set ADTS0 twice. please tell if the code is ok and comment need to be updated. tnx ADCSRB |= _BV(ADTS0) | _BV(ADTS0) | _BV(ADTS2); //Attach ADC start to TIMER1 Capture interrupt flag — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

i got it, thank you for the response. its a while . its risky to touch any thing when they'r working fine