nRF24 / RF24Mesh

OSI Layer 7 Mesh Networking for RF24Network & nrf24L01+ & nrf52x devices
http://nrf24.github.io/RF24Mesh
GNU General Public License v2.0
421 stars 154 forks source link

address build warnings about ncurses example #243

Closed 2bndy5 closed 1 month ago

2bndy5 commented 1 month ago

resolves #241

2bndy5 commented 1 month ago

According to the example's comment, https://github.com/nRF24/RF24Mesh/blob/2fb4d25a4f789370b88063cfcf20a2cfe93cf6ff/examples_RPi/ncurses/RF24Mesh_Ncurses_Master.cpp#L14 If it is true, I think this needs to be updated to say

  * NOTE: RF24MESH_DEBUG MUST BE DISABLED IN RF24Mesh_config.h 

I also noticed that every time I run this example without a pre-existing dhcplist.txt, a non-existent child node of ID 8 was assigned the address 01.

This doesn't happen in pyrf24 package, so I think this is related to a recent change (or somehow specific to this example).

2bndy5 commented 1 month ago

I also noticed that every time I run this example without a pre-existing dhcplist.txt, a non-existent child node of ID 8 was assigned the address 01.

I found it. https://github.com/nRF24/RF24Mesh/blob/2fb4d25a4f789370b88063cfcf20a2cfe93cf6ff/examples_RPi/ncurses/RF24Mesh_Ncurses_Master.cpp#L56

I suppose this is expected behavior given the above example-specific code.

TMRh20 commented 1 month ago

https://github.com/nRF24/RF24Mesh/blob/2fb4d25a4f789370b88063cfcf20a2cfe93cf6ff/examples_RPi/ncurses/RF24Mesh_Ncurses_Master.cpp#L56

I suppose this is expected behavior given the above example-specific code.

Hmm, I thought we'd removed that line from all the examples. It should be removed, an old artifact from testing.

If it is true, I think this needs to be updated to say

  * NOTE: RF24MESH_DEBUG MUST BE DISABLED IN RF24Mesh_config.h 

Agreed. Can you add these changes to this PR?

2bndy5 commented 1 month ago

I've already updated the intro comment. I'll remove that line about setting a static address.

2bndy5 commented 1 month ago

cherry picked to v1.x