search

nRF24 / RF24Network

OSI Layer 3 Networking for nRF24L01(+) and nRF52x on Arduino and Raspberry Pi
https://nrf24.github.io/RF24Network/
GNU General Public License v2.0
353 stars 163 forks source link

nrf_to_nrf.h expected for any nRF5x board in CI #200

Closed 2bndy5 closed 1 year ago

2bndy5 commented 1 year ago

Since nrf_to_nrf isn't a named lib dependency, the lib is not installed in CI and fails on the Arduino 33 Nano BLE board.

Solution

Just make nrf_to_nrf a dependency and install it CI.

2bndy5 commented 1 year ago

Installing nrf_to_nrf in CI yields a problem with the lib examples on a nRF5x board:

 /home/runner/work/RF24Network/RF24Network/examples/helloworld_rx/helloworld_rx.ino:25: undefined reference to `RF24Network::RF24Network(RF24&)'
   collect2: error: ld returned 1 exit status

So, the way it is set up currently, any nRF5x board is hard coded to only support the internal radio. I had imagined we would overload the c'tor rather than replace it. That way people can still use internal BLE + an external nRF24 module

For now, I think I'll just remove the Arduino 33 BLE Nano from the Arduino CI until this integration is fleshed out. Honestly, I think it should be explored on a separate branch though - we got lucky that none of the changes to master affect Linux.