nRF24 / RF24Network

OSI Layer 3 Networking for nRF24L01(+) and nRF52x on Arduino and Raspberry Pi
https://nrf24.github.io/RF24Network/
GNU General Public License v2.0
355 stars 164 forks source link

Extra Pipes #215

Closed TMRh20 closed 1 year ago

TMRh20 commented 1 year ago

Finally found some time to play around with this and it was pretty easy to implement. Just a few questions now like whether to try and support mixed networks (I don't really like that idea) but it seems to work fine.

Instructions:

201

2bndy5 commented 1 year ago

Citing a concern from #201 OP

pipe/address validation will have to conditionally forego x <= 5 presumption about 6 pipes

I think is_valid_address() needs tweaking: https://github.com/nRF24/RF24Network/blob/a334fa6ec420b2beedaf617018c11847cea80402/RF24Network.cpp#L1134-L1138

TMRh20 commented 1 year ago

I have it in the PR: https://github.com/nRF24/RF24Network/pull/215/files#diff-8a8080552c7f675fa680e629d5c5baa2c875d8334cbd57d38b0e44bfc328b751R1134