Disabled modules still register the ServiceProvider

nWidart / laravel-modules

Module Management In Laravel

https://docs.laravelmodules.com

MIT License

5.5k stars 954 forks source link

Disabled modules still register the ServiceProvider #1950

Closed locnguyen1842 closed 1 week ago

locnguyen1842 commented 2 weeks ago

Versions:

laravel-modules Version: 11.1.1
Laravel Version: 11.23
PHP Version: 8.3

Description:

The module service provider still load( register ) even it was disabled

Steps To Reproduce:

alissn commented 2 weeks ago

Hi @locnguyen1842,

Did you disable the module using the command php artisan module:disable?

If not, you should run the following command to clear any compiled modules:

php artisan module:clear-compiled

locnguyen1842 commented 2 weeks ago

hi @alissn , yes i'm using the command php artisan module:disable but it is not working

alissn commented 1 week ago

Hi @locnguyen1842,

Although there are events for creating, deleting, disabling, and enabling modules to clear the bootstrap/cache/module.php file, it seems that these events aren't functioning as expected.

i create new pull request to revet register of the providers to previous version. #1952