nWidart / laravel-modules

Module Management In Laravel
https://docs.laravelmodules.com
MIT License
5.5k stars 954 forks source link

ERROR Module [Abc] already exists! while creating new Module if Seeder Generations is false #1956

Open winavin opened 1 week ago

winavin commented 1 week ago

Versions:

Description:

Getting error while creating 2nd module. 1 module created successfully but after that each module creation gives error ERROR: Module [Award] already exists! when I run command php artisan module:make Award

This error only occurs when in config value paths.generator.seeder => ['path' => 'database/seeders', 'generate' => false]

when it is true, Modules genrated successfully.

my full config is:

<?php

use Nwidart\Modules\Activators\FileActivator;
use Nwidart\Modules\Providers\ConsoleServiceProvider;

return [

    /*
    |--------------------------------------------------------------------------
    | Module Namespace
    |--------------------------------------------------------------------------
    |
    | Default module namespace.
    |
    */
    'namespace' => 'Modules',

    /*
    |--------------------------------------------------------------------------
    | Module Stubs
    |--------------------------------------------------------------------------
    |
    | Default module stubs.
    |
    */
    'stubs' => [
        'enabled' => false,
        'path' => base_path('vendor/nwidart/laravel-modules/src/Commands/stubs'),
        'files' => [
            'routes/web' => 'routes/web.php',
            'routes/api' => 'routes/api.php',
//            'views/index' => 'resources/views/index.blade.php',
//            'views/master' => 'resources/views/layouts/master.blade.php',
            'scaffold/config' => 'config/config.php',
            'composer' => 'composer.json',
//            'assets/js/app' => 'resources/assets/js/app.js',
//            'assets/sass/app' => 'resources/assets/sass/app.scss',
//            'vite' => 'vite.config.js',
//            'package' => 'package.json',
        ],
        'replacements' => [
            'routes/web' => ['LOWER_NAME', 'STUDLY_NAME', 'MODULE_NAMESPACE', 'CONTROLLER_NAMESPACE'],
            'routes/api' => ['LOWER_NAME', 'STUDLY_NAME', 'MODULE_NAMESPACE', 'CONTROLLER_NAMESPACE'],
            'vite' => ['LOWER_NAME', 'STUDLY_NAME'],
            'json' => ['LOWER_NAME', 'STUDLY_NAME', 'MODULE_NAMESPACE', 'PROVIDER_NAMESPACE'],
            'views/index' => ['LOWER_NAME'],
            'views/master' => ['LOWER_NAME', 'STUDLY_NAME'],
            'scaffold/config' => ['STUDLY_NAME'],
            'composer' => [
                'LOWER_NAME',
                'STUDLY_NAME',
                'VENDOR',
                'AUTHOR_NAME',
                'AUTHOR_EMAIL',
                'MODULE_NAMESPACE',
                'PROVIDER_NAMESPACE',
                'APP_FOLDER_NAME',
            ],
        ],
        'gitkeep' => true,
    ],
    'paths' => [
        /*
        |--------------------------------------------------------------------------
        | Modules path
        |--------------------------------------------------------------------------
        |
        | This path is used to save the generated module.
        | This path will also be added automatically to the list of scanned folders.
        |
        */
        'modules' => base_path('Modules'),

        /*
        |--------------------------------------------------------------------------
        | Modules assets path
        |--------------------------------------------------------------------------
        |
        | Here you may update the modules' assets path.
        |
        */
        'assets' => public_path('modules'),

        /*
        |--------------------------------------------------------------------------
        | The migrations' path
        |--------------------------------------------------------------------------
        |
        | Where you run the 'module:publish-migration' command, where do you publish the
        | the migration files?
        |
        */
        'migration' => base_path('database/migrations'),

        /*
        |--------------------------------------------------------------------------
        | The app path
        |--------------------------------------------------------------------------
        |
        | app folder name
        | for example can change it to 'src' or 'App'
        */
        'app_folder' => 'app/',

        /*
        |--------------------------------------------------------------------------
        | Generator path
        |--------------------------------------------------------------------------
        | Customise the paths where the folders will be generated.
        | Setting the generate key to false will not generate that folder
        */
        'generator' => [
            // app/
            'actions' => ['path' => 'app/Actions', 'generate' => false],
            'casts' => ['path' => 'app/Casts', 'generate' => false],
            'channels' => ['path' => 'app/Broadcasting', 'generate' => false],
            'class' => ['path' => 'app/Classes', 'generate' => false],
            'command' => ['path' => 'app/Console', 'generate' => false],
            'component-class' => ['path' => 'app/View/Components', 'generate' => false],
            'emails' => ['path' => 'app/Emails', 'generate' => false],
            'event' => ['path' => 'app/Events', 'generate' => false],
            'enums' => ['path' => 'app/Enums', 'generate' => false],
            'exceptions' => ['path' => 'app/Exceptions', 'generate' => false],
            'jobs' => ['path' => 'app/Jobs', 'generate' => false],
            'helpers' => ['path' => 'app/Helpers', 'generate' => false],
            'interfaces' => ['path' => 'app/Interfaces', 'generate' => false],
            'listener' => ['path' => 'app/Listeners', 'generate' => false],
            'model' => ['path' => 'app/Models', 'generate' => false],
            'notifications' => ['path' => 'app/Notifications', 'generate' => false],
            'observer' => ['path' => 'app/Observers', 'generate' => false],
            'policies' => ['path' => 'app/Policies', 'generate' => false],
            'provider' => ['path' => 'app/Providers', 'generate' => true],
            'repository' => ['path' => 'app/Repositories', 'generate' => false],
            'resource' => ['path' => 'app/Resources', 'generate' => false],
            'route-provider' => ['path' => 'app/Providers', 'generate' => true],
            'rules' => ['path' => 'app/Rules', 'generate' => false],
            'services' => ['path' => 'app/Services', 'generate' => false],
            'scopes' => ['path' => 'app/Models/Scopes', 'generate' => false],
            'traits' => ['path' => 'app/Traits', 'generate' => false],

            // app/Http/
            'controller' => ['path' => 'app/Http/Controllers', 'generate' => true],
            'filter' => ['path' => 'app/Http/Middleware', 'generate' => false],
            'request' => ['path' => 'app/Http/Requests', 'generate' => false],

            // config/
            'config' => ['path' => 'config', 'generate' => false],

            // database/
            'factory' => ['path' => 'database/factories', 'generate' => false],
            'migration' => ['path' => 'database/migrations', 'generate' => false],
            'seeder' => ['path' => 'database/seeders', 'generate' => false],

            // lang/
            'lang' => ['path' => 'lang', 'generate' => false],

            // resource/
            'assets' => ['path' => 'resources/assets', 'generate' => false],
            'component-view' => ['path' => 'resources/views/components', 'generate' => false],
            'views' => ['path' => 'resources/views', 'generate' => false],

            // routes/
            'routes' => ['path' => 'routes', 'generate' => true],

            // tests/
            'test-feature' => ['path' => 'tests/Feature', 'generate' => false],
            'test-unit' => ['path' => 'tests/Unit', 'generate' => false],
        ],
    ],

    /*
    |--------------------------------------------------------------------------
    | Auto Discover of Modules
    |--------------------------------------------------------------------------
    |
    | Here you configure auto discover of module
    | This is useful for simplify module providers.
    |
    */
    'auto-discover' => [
        /*
        |--------------------------------------------------------------------------
        | Migrations
        |--------------------------------------------------------------------------
        |
        | This option for register migration automatically.
        |
        */
        'migrations' => true,

        /*
        |--------------------------------------------------------------------------
        | Translations
        |--------------------------------------------------------------------------
        |
        | This option for register lang file automatically.
        |
        */
        'translations' => false,

    ],

    /*
    |--------------------------------------------------------------------------
    | Package commands
    |--------------------------------------------------------------------------
    |
    | Here you can define which commands will be visible and used in your
    | application. You can add your own commands to merge section.
    |
    */
    'commands' => ConsoleServiceProvider::defaultCommands()
        ->merge([
            // New commands go here
        ])->toArray(),

    /*
    |--------------------------------------------------------------------------
    | Scan Path
    |--------------------------------------------------------------------------
    |
    | Here you define which folder will be scanned. By default will scan vendor
    | directory. This is useful if you host the package in packagist website.
    |
    */
    'scan' => [
        'enabled' => false,
        'paths' => [
            base_path('vendor/*/*'),
        ],
    ],

    /*
    |--------------------------------------------------------------------------
    | Composer File Template
    |--------------------------------------------------------------------------
    |
    | Here is the config for the composer.json file, generated by this package
    |
    */
    'composer' => [
        'vendor' => env('MODULE_VENDOR', 'nwidart'),
        'author' => [
            'name' => env('MODULE_AUTHOR_NAME', 'Nicolas Widart'),
            'email' => env('MODULE_AUTHOR_EMAIL', 'n.widart@gmail.com'),
        ],
        'composer-output' => false,
    ],

    /*
    |--------------------------------------------------------------------------
    | Choose what laravel-modules will register as custom namespaces.
    | Setting one to false will require you to register that part
    | in your own Service Provider class.
    |--------------------------------------------------------------------------
    */
    'register' => [
        'translations' => true,
        /**
         * load files on boot or register method
         */
        'files' => 'register',
    ],

    /*
    |--------------------------------------------------------------------------
    | Activators
    |--------------------------------------------------------------------------
    |
    | You can define new types of activators here, file, database, etc. The only
    | required parameter is 'class'.
    | The file activator will store the activation status in storage/installed_modules
    */
    'activators' => [
        'file' => [
            'class' => FileActivator::class,
            'statuses-file' => base_path('modules_statuses.json'),
        ],
    ],

    'activator' => 'file',
];

Steps To Reproduce:

make an module this module will generate successfully.

make another module this will fail

Composer Output

php artisan module:make Award

   INFO  Creating module: [Award].  

  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/Award/module.json ................................................. 0.87ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/Award/routes/web.php .............................................. 0.92ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/Award/routes/api.php .............................................. 0.76ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/Award/config/config.php ........................................... 0.67ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/Award/composer.json ............................................... 0.95ms DONE
  Generating file C:/xampp/htdocs/renewe/staff/staff-backend/Modules/Award/app/Providers/AwardServiceProvider.php ...................... 0.68ms DONE
  Generating file C:/xampp/htdocs/renewe/staff/staff-backend/Modules/Award/app/Providers/EventServiceProvider.php ...................... 0.70ms DONE
  Generating file C:/xampp/htdocs/renewe/staff/staff-backend/Modules/Award/app/Providers/RouteServiceProvider.php ...................... 0.32ms DONE
  Generating file C:/xampp/htdocs/renewe/staff/staff-backend/Modules/Award/app/Http/Controllers/AwardController.php .................... 0.49ms DONE

   INFO  Module [Award] created successfully.  

C:\xampp\htdocs\renewe\staff\staff-backend
php artisan module:make News

   INFO  Creating module: [News].  

  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/News/module.json .................................................. 0.66ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/News/routes/web.php ............................................... 0.60ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/News/routes/api.php ............................................... 0.46ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/News/config/config.php ............................................ 1.87ms DONE
  Generating file C:\xampp\htdocs\renewe\staff\staff-backend\Modules/News/composer.json ................................................ 0.76ms DONE

   Nwidart\Modules\Exceptions\ModuleNotFoundException 

  Module [News] does not exist!

  at vendor\nwidart\laravel-modules\src\FileRepository.php:312
    308▕         if ($module !== null) {
    309▕             return $module;
    310▕         }
    311▕ 
  ➜ 312▕         throw new ModuleNotFoundException("Module [{$name}] does not exist!");
    313▕     }
    314▕ 
    315▕     /**
    316▕      * Get all modules as laravel collection instance.

  1   vendor\nwidart\laravel-modules\src\Traits\ModuleCommandTrait.php:11
      Nwidart\Modules\FileRepository::findOrFail("News")

  2   vendor\nwidart\laravel-modules\src\Commands\Make\ProviderMakeCommand.php:100
      Nwidart\Modules\Commands\Make\ProviderMakeCommand::getModuleName()