Closed renanBritz closed 6 years ago
It's planned yes. I haven't had the time to do so myself. The migration should be very easy though.
Master branch is using 5.7, but some tests fail for an unknown reason.
Build log: https://travis-ci.org/nWidart/laravel-modules/jobs/428662632
If someone has an idea, it would be much appreciated.
There a exception ( enabled it using $this->withExceptionHandling();
)
1) Nwidart\Modules\Tests\Commands\ModuleMakeCommandTest::it_still_generates_module_if_it_exists_using_force_flag
Error: Class 'Modules\Blog\Providers\BlogServiceProvider' not found
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php:208
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php:144
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php:61
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/Laravel/Module.php:27
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/Module.php:251
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/FileRepository.php:299
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/Providers/BootstrapServiceProvider.php:22
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:572
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/ModulesServiceProvider.php:38
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/src/LaravelModulesServiceProvider.php:15
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:29
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:87
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:31
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Container/Container.php:564
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:793
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:776
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:777
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/BootProviders.php:17
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:310
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/Concerns/CreatesApplication.php:202
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/TestCase.php:73
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/Concerns/Testing.php:59
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/vendor/orchestra/testbench-core/src/TestCase.php:41
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/tests/BaseTestCase.php:12
/Users/kabbouchi/Sites/laravel57/deletemelaster-/laravel-modules/tests/Commands/ModuleMakeCommandTest.php:23
Indeed, but why is the question. When I stopped the test in mid process, I could see the module there.
I was wondering if this is still failing on 5.7? I forked the repository and the tests are passing locally. Thank you!
Support is already available if you use 4.0-dev
, but i'll tag it at some point soon.
4.0.0 was just tagged. Thanks again for the help @KABBOUCHI !
Hai im getting an error on laravel 5.7 while running publish command, like "Argument 2 passed to Illuminate\Routing\UrlGenerator::__construct() must be an instance of Illuminate\Http\Request, null given" Please Help
Strange error. You can try to debug it by understanding why it's getting null.
Hello!
Any plans on laravel 5.7 support?
Regards!