na0607 / jgrasstools

Automatically exported from code.google.com/p/jgrasstools
0 stars 0 forks source link

Magnitudo and TestMagnitudo #21

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Add horton magnitudo and its test

Original issue reported on code.google.com by formeppe@gmail.com on 3 Aug 2010 at 9:22

Attachments:

GoogleCodeExporter commented 8 years ago
Hi Giuseppe, I ask you to to two changes please:
- do not use a variable 
private static final double NaN = doubleNovalue;

This is not right, since it is not sure that the novalue is NaN. 

- rename the variable:

ModelsEngine prova = new ModelsEngine();

to something that makes sense.

- rename the Magnitudo class to be uppercase. in jgrastools we obey to the java 
rules to keep classes names uppercase.

I will then apply your patch.

Thanks

Original comment by andrea.a...@gmail.com on 3 Aug 2010 at 9:29

GoogleCodeExporter commented 8 years ago
I modified the code, is it ok now? i hope, let me know

giuseppe

Original comment by formeppe@gmail.com on 4 Aug 2010 at 7:51

Attachments:

GoogleCodeExporter commented 8 years ago
Add progress monitor

Original comment by formeppe@gmail.com on 4 Aug 2010 at 4:58

Attachments:

GoogleCodeExporter commented 8 years ago
Giuseppe, you stiull have two classes, one that is named magnitudo.java and 
internally Magnitudo. How is it possible you do not have syntax errors????
-> 
hortonmachine/src/main/java/org/jgrasstools/hortonmachine/modules/network/magnit
udo/magnitudo.java

Please update and clean up your repo and try to do the patch again. You should 
always update before patching.

Not applying this patch as it is.

Original comment by andrea.a...@gmail.com on 5 Aug 2010 at 7:40

GoogleCodeExporter commented 8 years ago
After downloading a new repository i did this pacth. How is it?

Original comment by formeppe@gmail.com on 5 Aug 2010 at 11:29

Attachments:

GoogleCodeExporter commented 8 years ago
Applied on trunk

Original comment by andrea.a...@gmail.com on 9 Aug 2010 at 7:08