search

naXa777 / SoundRecorder

A simple sound recording Android app implementing Material Design
https://naxa777.github.io/SoundRecorder/
GNU General Public License v3.0
35 stars 42 forks source link

sound replaying #70

Open cweng777 opened 4 years ago

cweng777 commented 4 years ago

Hi, at the "SAVED RECORDINGS" screen, if the user's permission is not granted, the first time to pause during the replaying will fail. Here is the bug report: Environment Android mobile phone/emulator App version : 2.0.2 Device model : Galaxy J7, emulator Android version : 6.0.1, 9 Steps to reproduce Go to setting-> find the SoundRecorder app-> remove the storage permission -> open the SoundRecorder app->select the "SAVED RECORDINGS" screen -> select one sound file->click play button to replay as the dialog shows -> The system will ask the permission, click "allow" -> click the pause button Expected Result Replaying stops Actual Result Replaying continues Visual Proof (video) https://media.oregonstate.edu/media/t/0_tc3cie01

cweng777 commented 4 years ago

I fixed it by changing one variable in PlaybackFragment. There is one control variable "isPlaying" which should be true after the user gives the storage permission. Otherwise, the first time to pause will fail. Here is the video of my change: https://media.oregonstate.edu/media/t/0_vv4a70e8 Thank you