naamiinepal / xrayto3D-benchmark

GNU General Public License v3.0
9 stars 3 forks source link

TLPredictor results missing in domain-shift & disaggregation results/figure/table #33

Closed msrepo closed 1 year ago

msrepo commented 1 year ago

Description

The following figure does not contain results from TLPredictor image image image

Files

hip_outdomain_clinic_metal.json hip_outdomain_clinic.json hip_outdomain_kits.json vertebra_outdomain_rsna.json

benchmark_table.py

Tasks

also, the colour for TL-Embedding and SwinUNETR clash.

benchmark_table not only creates the latex table but also evaluates domain shift results and saves them into json. The functionality is identical for both cases, making it sense to keep it in the table. But on the other hand, it does not hurt to separate them, the functionality common to both may be extracted and put into a utility function somewhere.

msrepo commented 1 year ago

corrected image image

The reviewer had correctly identified a mislabelling typo.

It is essential to investigate the reason behind the inconsistent performances of the OneDConcat model between Fig. 5 and Fig. 7. Notably, the performance of OneDConcat appears to be relatively low in Fig. 5, whereas it excels and achieves the best results in Fig. 7. image image

This updated figure now updates the correct labels.

msrepo commented 1 year ago

commit code for this issue